Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Source tree: Moved third party code to external directory#6915

Merged
gseguin merged 1 commit intomasterfrom
issue-6871
Jan 13, 2014
Merged

Source tree: Moved third party code to external directory#6915
gseguin merged 1 commit intomasterfrom
issue-6871

Conversation

@gseguin
Copy link
Contributor

@gseguin gseguin commented Jan 10, 2014

Fixes gh-6871

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) when pulling 2a214e6 on issue-6871 into d14b90d on master.

@ghost ghost assigned arschmitz Jan 10, 2014
@gseguin
Copy link
Contributor Author

gseguin commented Jan 11, 2014

@arschmitz, @rxaviers: for you review.

@arschmitz
Copy link
Contributor

squash and rebase then 👍

@gseguin gseguin merged commit abc9754 into master Jan 13, 2014
@gseguin gseguin deleted the issue-6871 branch January 13, 2014 21:17
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling abc9754 on issue-6871 into dfc5d32 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) when pulling abc9754 on issue-6871 into dfc5d32 on master.

@rxaviers
Copy link

👍 awesome

@jaspermdegroot
Copy link
Contributor

@gseguin

This change broke the demos on master: http://view.jquerymobile.com/master/demos/
We should also test the demos in a build.
The Backbone/Requirejs demo probably needs special attention because of the way scipts are loaded in that demo.

@gseguin
Copy link
Contributor Author

gseguin commented Jan 14, 2014

I will fix this later today.
On Jan 14, 2014 7:11 AM, "Jasper de Groot" notifications@github.com wrote:

@gseguin https://github.com/gseguin

This change broke the demos on master:
http://view.jquerymobile.com/master/demos/
We should also test the demos in a build.
The Backbone/Requirejs demo probably needs special attention because of
the way scipts are loaded in that demo.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6915#issuecomment-32267086
.

@gseguin
Copy link
Contributor Author

gseguin commented Jan 14, 2014

@uGoMobi, created #6942

@gseguin
Copy link
Contributor Author

gseguin commented Jan 14, 2014

PR #6943 submitted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposed directory layout for third party code

5 participants